[Defend Workflows][E2E]Endpoint e2e response console #155605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugins/security_solution/common/endpoint/index_data.ts
# Conflicts: # x-pack/plugins/security_solution/public/management/cypress/support/data_loaders.ts # x-pack/plugins/security_solution/public/management/cypress/support/plugin_handlers/endpoint_data_loader.ts # x-pack/plugins/security_solution/public/management/cypress/tasks/index_endpoint_hosts.ts # x-pack/plugins/security_solution/scripts/endpoint/agent_emulator/services/endpoint_response_actions.ts
# Conflicts: # x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts
…e-coverage-multipass
…e-coverage-multipass
szwarckonrad
changed the title
szwarckonrad
added
release_note:skip
# Conflicts: # x-pack/plugins/security_solution/public/management/cypress/e2e/mocked_data/isolate.cy.ts # x-pack/plugins/security_solution/public/management/cypress/tasks/isolate.ts
…nto endpoint-e2e-response-console
# Conflicts: # x-pack/plugins/security_solution/public/management/cypress/tasks/response_console.ts
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
…gling hosts from previous tests in the ci
paul-tavares
approved these changes
Apr 27, 2023
| import { | ||
| sendEndpointActionResponse, | ||
| sendFleetActionResponse, | ||
| } from '../../../../scripts/endpoint/agent_emulator/services/endpoint_response_actions'; |
There was a problem hiding this comment.
I suggest you don't use services from agent_meulator because they are private to that utility. I would propose you refactor the ones you need and move them to script/endpoint/common.
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
szwarckonrad
added a commit
to szwarckonrad/kibana
that referenced
this pull request
May 26, 2023
Depends on elastic#155519 E2E coverage of `isolate`, `processes`, `kill-process` and `suspend-process` commands on mocked endpoint. E2E coverage of the above but on real endpoint is [here](elastic#155519). Because these tests are run against mocked data I've decided not to mock `kill-process` and `suspend-process` outcome (whether process is actually killed/suspended) because it would mean testing mocks themselves. What is tested is the outcome the user sees ('Action completed'). --------- Co-authored-by: Patryk Kopycinski <[email protected]> (cherry picked from commit fd5309f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
szwarckonrad
added a commit
that referenced
this pull request
May 26, 2023
…158553) # Backport This will backport the following commits from `main` to `8.8`: - [[Defend Workflows][E2E]Endpoint e2e response console (#155605)](#155605) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-02T09:02:06Z","message":"[Defend Workflows][E2E]Endpoint e2e response console (#155605)\n\nDepends on https://github.com/elastic/kibana/pull/155519\r\n\r\nE2E coverage of `isolate`, `processes`, `kill-process` and\r\n`suspend-process` commands on mocked endpoint.\r\n\r\nE2E coverage of the above but on real endpoint is\r\n[here](https://github.com/elastic/kibana/pull/155519).\r\n\r\nBecause these tests are run against mocked data I've decided not to mock\r\n`kill-process` and `suspend-process` outcome (whether process is\r\nactually killed/suspended) because it would mean testing mocks\r\nthemselves. What is tested is the outcome the user sees ('Action\r\ncompleted').\r\n\r\n---------\r\n\r\nCo-authored-by: Patryk Kopycinski <[email protected]>","sha":"fd5309f6a02bce641c4baf79500acfe797e294f7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.8.0","v8.9.0"],"number":155605,"url":"https://github.com/elastic/kibana/pull/155605","mergeCommit":{"message":"[Defend Workflows][E2E]Endpoint e2e response console (#155605)\n\nDepends on https://github.com/elastic/kibana/pull/155519\r\n\r\nE2E coverage of `isolate`, `processes`, `kill-process` and\r\n`suspend-process` commands on mocked endpoint.\r\n\r\nE2E coverage of the above but on real endpoint is\r\n[here](https://github.com/elastic/kibana/pull/155519).\r\n\r\nBecause these tests are run against mocked data I've decided not to mock\r\n`kill-process` and `suspend-process` outcome (whether process is\r\nactually killed/suspended) because it would mean testing mocks\r\nthemselves. What is tested is the outcome the user sees ('Action\r\ncompleted').\r\n\r\n---------\r\n\r\nCo-authored-by: Patryk Kopycinski <[email protected]>","sha":"fd5309f6a02bce641c4baf79500acfe797e294f7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155605","number":155605,"mergeCommit":{"message":"[Defend Workflows][E2E]Endpoint e2e response console (#155605)\n\nDepends on https://github.com/elastic/kibana/pull/155519\r\n\r\nE2E coverage of `isolate`, `processes`, `kill-process` and\r\n`suspend-process` commands on mocked endpoint.\r\n\r\nE2E coverage of the above but on real endpoint is\r\n[here](https://github.com/elastic/kibana/pull/155519).\r\n\r\nBecause these tests are run against mocked data I've decided not to mock\r\n`kill-process` and `suspend-process` outcome (whether process is\r\nactually killed/suspended) because it would mean testing mocks\r\nthemselves. What is tested is the outcome the user sees ('Action\r\ncompleted').\r\n\r\n---------\r\n\r\nCo-authored-by: Patryk Kopycinski <[email protected]>","sha":"fd5309f6a02bce641c4baf79500acfe797e294f7"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #155519
E2E coverage of
isolate,processes,kill-processandsuspend-processcommands on mocked endpoint.E2E coverage of the above but on real endpoint is here.
Because these tests are run against mocked data I've decided not to mock
kill-processandsuspend-processoutcome (whether process is actually killed/suspended) because it would mean testing mocks themselves. What is tested is the outcome the user sees ('Action completed').